RFR: 8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode

Igor Ignatyev iignatyev at openjdk.java.net
Thu Jun 10 08:02:24 UTC 2021


Hi all,

could you please review this small and test-only change for `resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java` test?

the test's main class just orchestrates execution and hence should be run in a driver mode, the patch also makes small refactoring of the test code: removes redundant imports, simplifies process creation, and adds checks of the exit code.

testing: `resourcehogs/serviceability` tests on `{linux,windows,macosx}-x64`

Thanks,
-- Igor

-------------

Commit messages:
 - check exit code of jar and GetObjectSizeOverflowAgent processes
 - simply jar process creation
 - cleaned up imports
 - use try-with-resource
 - 8268530

Changes: https://git.openjdk.java.net/jdk/pull/4452/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4452&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268530
  Stats: 11 lines in 1 file changed: 1 ins; 4 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4452.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4452/head:pull/4452

PR: https://git.openjdk.java.net/jdk/pull/4452


More information about the serviceability-dev mailing list