[jdk17] RFR: 8268564: mark hotspot serviceability/attach tests which ignore external VM flags

Chris Plummer cjplummer at openjdk.java.net
Thu Jun 10 21:29:52 UTC 2021


On Thu, 10 Jun 2021 18:23:45 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this one-liner that adds `@requires vm.flagless` to 2 `serviceability/attach` tests that ignore external VM flags?
> 
> Thanks,
> -- Igor

Can you explain a bit more how `@requires vm.flagless` works? The way I read it, that would indicate that the test should not be run if any flags are specified. I'm not sure why you would want to do that. I understand that the test itself launches a subprocess without passing on the flags, but I don't see why that would preclude running the test if any flags are specified.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/8


More information about the serviceability-dev mailing list