RFR: 8268698: Use Objects.check{Index, FromToIndex, FromIndexSize} where possible

David Holmes david.holmes at oracle.com
Thu Jun 17 12:25:07 UTC 2021


On 17/06/2021 8:50 pm, Alan Bateman wrote:
> On Thu, 17 Jun 2021 05:16:14 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> There are a lot more tests than just tier1. :) I don't expect many, if any, tests to be looking for a specific IOOBE message, and I can't see an easy way to find such tests without running them. If core-libs folk are okay with this update then I guess we can just handle any test failures if they arise. But I'll run this through our tier 1-3 testing.
> 
> It would be good to run tier 1-3. Off hand I can't think of any tests that are dependent on the exception message, I think I'm more concerned about changing behavior (once you throw a more specific IOOBE is some of the very core classes then it's hard to change it because libraries get dependent on the more specific exception).

tiers 1-3 on Linux-x64 passed okay.

Any change to the exact type of exception thrown should be affirmed 
through a CSR request.

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4507
> 


More information about the serviceability-dev mailing list