RFR: 8268857: Merge three vm operations in thread_dump [v3]

David Holmes david.holmes at oracle.com
Fri Jun 18 03:20:37 UTC 2021


On 18/06/2021 12:29 pm, Denghui Dong wrote:
> On Thu, 17 Jun 2021 23:12:04 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> Sorry still not a fan even with the hacked in deadline support for find_deadlocks. It is too arbitrary - you have no idea what constitutes a reasonable deadline, nor by how much you may overshoot that deadline.
>>
>> David
> 
> Hi David,
> 
> Thanks for the comment.
> 
> Yes, there is no good way to determine a suitable deadline.
> 
> I intend to temporarily give up the idea of combining VM_FindDeadlocks into VM_ExtendedPrintThreads.
> 
> But I think we can at least merge `VM_PrintJNI` and `VM_PrintThreads`, because the implementation of `VM_PrintJNI` is very fast. What do you think?

Yes that seems fine in terms of lengthening the safepoint.

Thanks,
David
-----

> Denghui
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4504
> 


More information about the serviceability-dev mailing list