RFR: JDK-8268893: jcmd to trim the glibc heap [v2]

David Holmes david.holmes at oracle.com
Mon Jun 21 12:11:41 UTC 2021


On 21/06/2021 7:58 pm, Thomas Stuefe wrote:
> On Mon, 21 Jun 2021 09:15:05 GMT, Volker Simonis <simonis at openjdk.org> wrote:
> 
>> I like this little new diagnostic command which I think can be quite useful in specific situations.
>>
> 
> Thanks a lot Volker!
> 
>> However, in contrast to other reviewers, I'd rather keep this simple and Glibc specific instead of extending it to a more general but mostly empty command.
> 
> Yes, that was my thought too. Lets wait for @dholmes-ora to chime in, whether we can all agree on a glibc specific variant. I also preferred that one.

I don't totally oppose the specialised variant, but it certainly isn't 
my ideal solution. Not sure if we already have platform specific dcmds? 
This will need a CSR request anyway.

Cheers,
David

>>
>> I'd therefore propose to rename this command to `glibc_trim_heap` to make it evident from the command name already that it is Glibc-specific.
>>
>> Besides that, just cosmetic changes and suggestions.
> 
> All of which make sense, I'll work them in.
> 
> Thanks!
> 
> ..Thomas
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4510
> 


More information about the serviceability-dev mailing list