RFR: 8256306: ObjectMonitor::_contentions field should not be 'jint' [v2]

David Holmes dholmes at openjdk.java.net
Tue Jun 22 23:53:27 UTC 2021


On Tue, 22 Jun 2021 21:07:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I changed the _contentions and _waiters fields from jint to int and ran tests tier1-3.  Tested tier1 with linux, mac, windows platforms. Also changed the _previous_owner_tid to unintptr_t from jlong, since that's what the cast did.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix INT32_MIN and cache padding.

Looks good!

Good catch on the padding @dcubed-ojdk !

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3980


More information about the serviceability-dev mailing list