RFR: 8253119: Remove the legacy PlainSocketImpl and PlainDatagramSocketImpl implementation [v4]
Patrick Concannon
pconcannon at openjdk.java.net
Fri Jun 25 10:25:53 UTC 2021
On Thu, 24 Jun 2021 15:06:49 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>>> I've created an issue to track this: https://bugs.openjdk.java.net/browse/JDK-8269288
>>
>> Thanks. So are you keeping the Objects.requireNonNull here? If so then it should probably be the 2-arg version so that the message is clear that the custom DatagramSocketFactory returned null, otherwise it will look like a DS bug.
>
> @AlanBateman Ah - good idea - something like "implementation returned by installed DatagramSocketFactoryImpl is null"?
> Maybe we could add the name of the concrete DatagramSocketFactoryImpl class too?
OK. I've added a message to the null check now. See 36bcee3
-------------
PR: https://git.openjdk.java.net/jdk/pull/4574
More information about the serviceability-dev
mailing list