[jdk17] RFR: 8269302: serviceability/dcmd/framework/InvalidCommandTest.java still fails after JDK-8268433

Daniel D.Daugherty dcubed at openjdk.java.net
Fri Jun 25 20:29:01 UTC 2021


On Fri, 25 Jun 2021 18:11:27 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> Please review this simple test fix for jdk17.
> 
> The cycle should run until connection is established (connection.isConnected() returns true) or error occurred (error != null)
> This wrong condition causes test error if ListenerThread.getConnection() reaches "synchronized (this)" section earlier than ListenerThread.run()

Thumbs up.

This looks like a trivial fix to me. I don't see any mention of
testing. It looks like the two tests mentioned in the bug both
run in Tier1 on multiple platforms.

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/150


More information about the serviceability-dev mailing list