RFR: 8268425: Show decimal nid of OSThread instead of hex format one
Kevin Walls
kevinw at openjdk.java.net
Mon Jun 28 13:10:04 UTC 2021
On Fri, 18 Jun 2021 06:14:49 GMT, Yi Yang <yyang at openjdk.org> wrote:
> Do you think this would facilitate debugging process? And is it acceptable? Any feedback is appreciated!
My first comments were to say that this makes things better for some people, but a little worse for others.
Maybe overall this looks like it makes things better for most people. 8-)
If so (and if we don't discover more tools that prefer hex for thread IDs!), then we want to be consistent, so in addition to the native/built in implementation, we should also update:
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java
..to keep the SA implementation in sync. It would be odd to have thread dumps looking more different depending on what generated them.
And if changing that, also change:
test/hotspot/jtreg/serviceability/sa/JhsdbThreadInfoTest.java
I don't see other tests that parse this information.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4449
More information about the serviceability-dev
mailing list