RFR: 8261710: SA DSO objects have sizes that are too large [v5]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Mon Mar 1 04:24:40 UTC 2021


On Sat, 20 Feb 2021 12:28:05 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> Marked as reviewed by sspitsyn (Reviewer).
>
> @sspitsyn Thanks for the review!
> 
>> > lib->end is declared as unsigned (uintptr_t), so we can't use (lib->end < aligned_end) when lib->end is set to -1.
> 
>> Could we use the 0L instead of -1L? What's wrong with 0L?
> 
> I prefer to use -1 instead of 0 for invalid value because we can't distinguish NULL or invalid value if we use 0.

PING: Can I get second reviewer?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2563


More information about the serviceability-dev mailing list