Integrated: 8261447: MethodInvocationCounters frequently run into overflow

Lutz Schmidt lucy at openjdk.java.net
Wed Mar 3 20:07:42 UTC 2021


On Wed, 10 Feb 2021 16:28:29 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

> Dear community,
> may I please request reviews for this fix, improving the usefulness of method invocation counters.
> - aggregation counters are retyped as uint64_t, shifting the overflow probability way out (> 500 years in case of a 1 GHz counter update frequency).
> - counters for individual methods are interpreted as (unsigned int), in contrast to their declaration as int. This gives us a factor of two before the counters overflow.
> - as a special case, "compiled_invocation_counter" is retyped as long, because it has a higher update frequency than other counters.
> - before/after sample output is attached to the bug description. 
> 
> Thank you!
> Lutz

This pull request has now been integrated.

Changeset: 268d9b79
Author:    Lutz Schmidt <lucy at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/268d9b79
Stats:     164 lines in 11 files changed: 51 ins; 4 del; 109 mod

8261447: MethodInvocationCounters frequently run into overflow

Reviewed-by: thartmann, mdoerr, kvn, iveresov

-------------

PR: https://git.openjdk.java.net/jdk/pull/2511


More information about the serviceability-dev mailing list