RFR: 8259577: Dangling reference to temp_path in Java_sun_tools_attach_VirtualMachineImpl_getTempDir

Chris Plummer cjplummer at openjdk.java.net
Thu Mar 4 19:18:55 UTC 2021


On Thu, 4 Mar 2021 18:27:48 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Hi,
> This is a pull request for 8259577, which points out that Java_sun_tools_attach_VirtualMachineImpl_getTempDir
> caches a local variable from a previous call, so could return garbage.
> However as noted in the bug, we have been safe so far because this method is only called once, so the caching is not required.
> Thanks.

Looks good, except you need to update the copyright.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2832


More information about the serviceability-dev mailing list