RFR: 8259577: Dangling reference to temp_path in Java_sun_tools_attach_VirtualMachineImpl_getTempDir [v2]

Kevin Walls kevinw at openjdk.java.net
Thu Mar 4 19:47:00 UTC 2021


> Hi,
> This is a pull request for 8259577, which points out that Java_sun_tools_attach_VirtualMachineImpl_getTempDir
> caches a local variable from a previous call, so could return garbage.
> However as noted in the bug, we have been safe so far because this method is only called once, so the caching is not required.
> Thanks.

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  Copyright update.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2832/files
  - new: https://git.openjdk.java.net/jdk/pull/2832/files/7eb29e4d..c660082f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2832&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2832&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2832.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2832/head:pull/2832

PR: https://git.openjdk.java.net/jdk/pull/2832


More information about the serviceability-dev mailing list