RFR: JDK-8261095: Add test for clhsdb "symbol" command [v3]

Chris Plummer cjplummer at openjdk.java.net
Wed Mar 10 05:20:08 UTC 2021


On Wed, 10 Mar 2021 04:54:03 GMT, Vipin Sharma <vsharma at openjdk.org> wrote:

>> After moving the filter to the next line also can not fit this in one line.
>> In addition to the filter, moving all characters starting from "new RuntimeException(...." also goes till 126 char.
>> Following is one suggestion, does it look good?
>> 
>> String threadAddress = classOutput.lines()
>>         .filter(part -> part.startsWith("java/lang/Thread"))
>>         .map(part -> part.split(" @"))
>>         .findFirst()
>>         .map(addresses -> addresses[1])
>>         .orElseThrow(() -> new RuntimeException(
>>                 "Cannot find address of the InstanceKlass for java.lang.Thread in output"));
>
> Formatting in my comment is not clear, so I have added one new commit for this.

Formatting looked fine in the email. Try putting it in a code block to prevent the auto formatting being done on it.

Latest webrev looks good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2863


More information about the serviceability-dev mailing list