RFR: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent" [v2]

[Alex Menkov]

On Wed, 10 Mar 2021 23:31:08 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reworked the fix accordingly feedback
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jdi/JDIBase.java line 171:
> 
>> 169:     // Waiting for ThreadStart and ThreadDeath event we can get events from system threads,
>> 170:     // so need to ensure we get the event from the desired thread.
>> 171:     protected void waitThreadStart(String threadName) throws JDITestRuntimeException {
> 
> I think this API is misnamed. It's not just waiting for a ThreadStart for the specified thread. It's waiting for any event other than ThreadStart for some other thread or ThreadDeath for any thread. That's a bit of an odd combination, and certainly not obvious based on the method name and description.

I reworked the fix. Hope now it's clearer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2927