RFR: 8263549: 8263412 can cause jtreg testlibrary split
Igor Ignatyev
iignatyev at openjdk.java.net
Sat Mar 13 04:38:48 UTC 2021
Hi all,
could you please review this dull patch that replaces `ClassFileInstaller` w/ `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to ensure we won't get split testlibrary, and removes `jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally used).
from JBS:
> after JDK-8263412, we might (again) encounter NCDFE b/c parts of testlibraries aren't on the classpath. this happens when jtreg builds `jdk.test.lib.helpers.ClassFileInstaller` as a part of test-specific code, but `ClassFileInstaller` as part of shared testibrary directory in one test, when in the following test, jtreg sees `ClassFileInstaller` in the shared directory, hence javac won't recompile it/its dependencies, but in runtime `jdk.test.lib.helpers.ClassFileInstaller` is nowhere to be found, hence we get NCDFE.
testing:
- [x] `grep ' ClassFileInstaller[^.]`
- [ ] tier1-3
Thanks,
-- Igor
-------------
Commit messages:
- fixup
- update copyright year
- rm test/lib/ClassFileInstaller.java
- 's/ ClassFileInstaller / jdk.test.lib.helpers.ClassFileInstaller /g'
Changes: https://git.openjdk.java.net/jdk/pull/2985/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2985&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8263549
Stats: 1736 lines in 867 files changed: 0 ins; 67 del; 1669 mod
Patch: https://git.openjdk.java.net/jdk/pull/2985.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2985/head:pull/2985
PR: https://git.openjdk.java.net/jdk/pull/2985
More information about the serviceability-dev
mailing list