RFR: 8262504: Some CLHSDB command cannot know they run on remote debugger

Serguei Spitsyn sspitsyn at openjdk.java.net
Mon Mar 15 23:38:08 UTC 2021


On Sun, 28 Feb 2021 13:18:21 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> `pmap` and `pstack` CLHSDB command do not work on remote debugger, we can see following error message:
> 
> hsdb> pmap
> not yet implemented (debugger does not support CDebugger)!
> 
> However, SA has different message for this purpose:
> 
> https://github.com/openjdk/jdk/blob/03d888f463c0a6e3fee70ed8ad606fc0a3082636/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/PMap.java#L74-L78
> 
> SA should show "remote configuration is not yet implemented" when it works on remote debugger.

Hi Yasumasa,
The fix looks good to me.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2766


More information about the serviceability-dev mailing list