RFR: 8263572: Output from jstack mixed mode is misaligned [v2]

Koichi Sakata ksakata at openjdk.java.net
Tue Mar 16 06:28:09 UTC 2021


On Mon, 15 Mar 2021 19:20:27 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Koichi Sakata has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix calculation for the length of white space
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/PStack.java line 85:
> 
>> 83:         }
>> 84:          final boolean cdbgCanDemangle = cdbg.canDemangle();
>> 85:          String fillerForAddress = " ".repeat(2 + (2 << VM.getVM().getLogAddressSize())) + "\t";
> 
> Why not use `2 * VM.getVM().getAddressSize()` rather than `(2 << VM.getVM().getLogAddressSize()`?

Thank you. I missed that method. I've changed the code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3004


More information about the serviceability-dev mailing list