RFR: 8262080: vmTestbase/nsk/jdi/Event/request/request001/TestDescription.java failed with "ERROR: new event is not ThreadStartEvent" [v4]

Serguei Spitsyn sspitsyn at openjdk.java.net
Wed Mar 17 01:14:07 UTC 2021


On Thu, 11 Mar 2021 23:17:24 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> The fix updates the test to skip ThreadStartEvent/ThreadDeathEvent from other threads
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reformatted comment

Alex,

The fix looks good.
One minor suggestion about the messages:
+                    log2("Got ThreadStartEvent for wrong thread: " + event);
+                    log2("Got ThreadDeathEvent for wrong thread: " + event);

More clear message would be something like:
  "Thread is not expected, skipping XXX event: " + ...

Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2927


More information about the serviceability-dev mailing list