RFR: 8263572: Output from jstack mixed mode is misaligned [v2]

Koichi Sakata ksakata at openjdk.java.net
Fri Mar 19 10:08:39 UTC 2021


On Tue, 16 Mar 2021 23:29:31 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Thank you for your comment, @plummercj.
>> 
>>> What testing have you done?
>> 
>> I added the content of the test that I've done in the body text.
>> 
>>> Please update the copyright to 2021.
>> 
>> Sure!
>> 
>>> I noticed that in you original jstack output there is only 1 space after the address, and now there appears to be multiple spaces. However, when I produce the jstack out there's already multiple spaces. Was there some formatting issue with your original output?
>> 
>> I'm sorry. It seemed that a tab after the address was lost on pasting. I pasted proper one once again. So there is no format issue after the address.
>
>> > What testing have you done?
>> 
>> I added the content of the test that I've done in the body text.
> 
> I was referring to the running of existing tests. I just want to make sure the format changes don't cause any tests to fail. It looks like the only test we have that uses `--mixed` is `test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackMixed.java`. This test is normally run as part of the git automated testing, but it is only run on linux, and I'm seeing the following in the test results:
> 
> `TEST RESULT: Passed. Skipped: jtreg.SkippedException: SA Attach not expected to work. Ptrace attach not supported.`
> 
> So it was skipped since the machine does not support Ptrace attach, and this was the only attempt to run the test.

Thank you. I understand it.

I ran that jtreg test by myself. `TestJhsdbJstackMixed.java` wasn't skipped and the execution was successful as follows.
$ sudo make run-test TEST=serviceability/sa/TestJhsdbJstackMixed.java

$ cat ./jdk/build/linux-x86_64-server-fastdebug/test-results/jtreg_test_hotspot_jtreg_serviceability_sa_TestJhsdbJstackMixed_java/text/summary.txt
serviceability/sa/TestJhsdbJstackMixed.java  Passed. Execution successful
I also added this test result to the body.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3004


More information about the serviceability-dev mailing list