RFR: 8264004: Don't use TRAPS if no exceptions are thrown [v2]

[Harold Seigel]

On Tue, 23 Mar 2021 01:22:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   missed THREAD that should be CHECK_false argument.

src/hotspot/share/oops/constantPool.cpp line 1426:

> 1424:     bool match_entry = compare_entry_to(k1, cp2, k2);
> 1425:     bool match_operand = compare_operand_to(i1, cp2, i2);
> 1426:     return (match_entry && match_operand);

Is it worth changing this to:  If (compare_entry_to(...) && compare_operand_to(..)) { .. }
Then if the first one is false the second call isn't needed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3141