RFR: 8264004: Don't use TRAPS if no exceptions are thrown [v4]
David Holmes
dholmes at openjdk.java.net
Tue Mar 23 23:28:40 UTC 2021
On Tue, 23 Mar 2021 16:08:59 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in ConstantPool merging functions.
>> Tested with vmTestbase/nsk/jvmti and tier1 (in progress).
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix load_new_class_versions and remove more traps.
Updates look good - thanks.
I agree with Ioi about adding ExceptionMark as part of this usage pattern - it captures the intent that no exceptions are allowed to escape.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3141
More information about the serviceability-dev
mailing list