RFR: 8264484: Replace uses of StringBuffer with StringBuilder in jdk.hotspot.agent [v2]

Andrey Turbanov github.com+741251+turbanoff at openjdk.java.net
Wed Mar 31 16:11:45 UTC 2021


On Wed, 31 Mar 2021 15:41:42 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8264484: Replace uses of StringBuffer with StringBuilder in jdk.hotspot.agent
>>   
>>   remove redundant local variables as suggested by reviewers
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java line 887:
> 
>> 885:    protected String genMultPCHref(String pcs) {
>> 886:       String buf = genBaseHref() + "pc_multiple=" + pcs;
>> 887:       return buf;
> 
> This is like VMVersionMismatchException.java above, where as it is reduced to two lines, we may as well reduce it to one line with:
> return genBaseHref() + ..etc... 
> 
> With these two minor changes, I think this looks good.

done

-------------

PR: https://git.openjdk.java.net/jdk/pull/3275


More information about the serviceability-dev mailing list