RFR: 8266187: Memory leak in appendBootClassPath() [v2]

Wang Huang whuang at openjdk.java.net
Sat May 1 04:15:14 UTC 2021


> Dear All, 
>     I find a memory leak in `appendBootClassPath()`
> https://github.com/openjdk/jdk/blob/75a2354dc276e107d64516d20fc72bc7ef3d5f86/src/java.instrument/share/native/libinstrument/InvocationAdapter.c#L950
> * we malloc `resolved` from resolve(parent, path)
> * we use `resolved` in line 951 
> * we don't free() this memory after using.
> 
> I think we can fix this bug by adding a free() after line 951 as my commit.
> Thank you for your review. Any suggestion is welcome.
> 
> Yours , 
> Wang Huang

Wang Huang has updated the pull request incrementally with one additional commit since the last revision:

  update copyright year

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3751/files
  - new: https://git.openjdk.java.net/jdk/pull/3751/files/c973192e..c2899578

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3751&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3751&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3751.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3751/head:pull/3751

PR: https://git.openjdk.java.net/jdk/pull/3751


More information about the serviceability-dev mailing list