RFR: 8221503: vmTestbase/nsk/jdb/eval/eval001/eval001.java fails with: com.sun.jdi.InvalidTypeException: Can't assign double[][][] to double[][][] [v2]

Fairoz Matte fmatte at openjdk.java.net
Mon May 3 04:17:54 UTC 2021


On Thu, 29 Apr 2021 07:58:26 GMT, Fairoz Matte <fmatte at openjdk.org> wrote:

>> findComponentType() logic is wrong. In findComponentType() method, We always get vm.classesByName() retruns empty list
>> list = vm.classesByName(parser.typeName());
>> We have "parser.typeName()" retruns " double[][]"
>> vm.classesByName("") is expecting the fully qualified name example "java.lang.Double"
>> This always returns empty list, resulting into ClassNotLoadedException as it assumes the Component class has not yet been loaded, hence the test case fails.
>> 
>> There was a suggested fix from Egor Ushakov from JetBrains, I am proposing the same to get this fix. I have verified the patch with required testing it works fine.
>
> Fairoz Matte has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update ArrayReferenceImpl.java
>  - Update ArrayTypeImpl.java

Hi Chris, thanks for the rreview.

> test/hotspot/jtreg/vmTestbase/nsk/jdb
> test/hotspot/jtreg/serviceability/jdwp
> test/hotspot/jtreg/vmTestbase/nsk/jdwp
> test/hotspot/jtreg/vmTestbase/nsk/jdi
> test/jdk/com/sun/jdi

I have verified tier1 to tier8 and didn't find any issues.
Could you please sponsor this push for me.

Thanks,

-------------

PR: https://git.openjdk.java.net/jdk/pull/3658


More information about the serviceability-dev mailing list