RFR: 8262002: java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh failed with "TestCaseScaffoldException: DummyClassWithLVT did not match .class file" [v2]

[Serguei Spitsyn]

On Wed, 21 Apr 2021 20:51:49 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> The test actually failed starting from jdk13, but the error is masked by JDK-8264667 (and shell part of the test didn't verify result of the java execution)
>> The fix:
>> - updates JvmtiClassFileReconstituter to add attributes in the same order as javac does
>> - makes the test java instead of shell
>> - added workaround for JDK-8264667
>> - test code is ready to ignore order of attributes
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated the fix accordingly feedback

Hi Alex,
Looks good to me.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3426