RFR: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap
Daniel Fuchs
dfuchs at openjdk.java.net
Wed May 5 17:27:02 UTC 2021
On Wed, 5 May 2021 15:59:43 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
> This fixes two javadoc tag references and several typos. References are fixed by removing whitespace before the opening `(`. That whitespace caused the opening `(` and the rest of the reference to be parsed as a link label.
>
> Since we are here, I think this class could also benefit from using modern APIs. This should be done in a separate PR though. For example:
>
> 1. Numerous instances of `Boolean.valueOf( <var> ).booleanValue()` could be changed to `Boolean.parseBoolean( <var> )`
> 2. `throw (IllegalArgumentException) new IllegalArgumentException(msg).initCause(e);` could be changed to `throw new IllegalArgumentException(msg, e);`
LGTM. Thanks for fixing the various typos.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3885
More information about the serviceability-dev
mailing list