RFR: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load

Thu May 6 16:42:53 UTC 2021

On Thu, 6 May 2021 16:31:57 GMT, Argha C <github.com+971473+argha-c at openjdk.org> wrote:

>> Thanks for linking that. It sounds reasonable to me to prefer `quota` in that case.
>
>> @argha-c The proposed fix is within the `quota > 0` condition. I.e. this is code only run when CPU quotas, _not_ shares are in effect. In docker/podman speach these are `--cpu-quota=...` and `--cpu-period=....` switches. So no, in this case it wouldn't make sense to use cpu shares info in a branch which looks at cpu quotas ;-)
> 
> @jerboaa : Correct. My comment was less specific to the branch, and more to highlight that a fix here needs to consider the case for both `quota` and `shares`. I see the bug report has been updated to reflect that. Cheers.

OK. Thanks for clarifying.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3656