RFR: 8196743: jstatd doesn't see new Java processes inside Docker container [v2]

Kevin Walls kevinw at openjdk.java.net
Fri May 7 09:15:15 UTC 2021


On Thu, 6 May 2021 23:54:49 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove tmpdirs member, call getTempDirectories() directly as needed.
>
> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/LocalVmManager.java line 79:
> 
>> 77:     public LocalVmManager(String user) {
>> 78:         this.userName = user;
>> 79:         setTempDirs();
> 
> Is this call necessary? It looks like we don't need to hold `tmpdirs` anymore. Can we remove `tmpdirs` from class member and can call `PerfDataFile.getTempDirectories()` directly at L138?

Hi - right, it's not necessary, I almost took it out, but had a minor concern about leaving tmpdirs unset.
But removing tmpdirs as a member is fine also.  That is testing well, will push an update shortly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3908


More information about the serviceability-dev mailing list