RFR: 8266567: Fix javadoc tag references in sun.management.jmxremote.ConnectorBootstrap [v3]
Serguei Spitsyn
sspitsyn at openjdk.java.net
Wed May 12 00:46:55 UTC 2021
On Tue, 11 May 2021 22:57:24 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> This fixes two javadoc tag references and several typos. References are fixed by removing whitespace before the opening `(`. That whitespace caused the opening `(` and the rest of the reference to be parsed as a link label.
>>
>> Since we are here, I think this class could also benefit from using modern APIs. This should be done in a separate PR though. For example:
>>
>> 1. Numerous instances of `Boolean.valueOf( <var> ).booleanValue()` could be changed to `Boolean.parseBoolean( <var> )`
>> 2. `throw (IllegalArgumentException) new IllegalArgumentException(msg).initCause(e);` could be changed to `throw new IllegalArgumentException(msg, e);`
>
> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>
> Reverted a previously fixed typo
Hi Pavel,
It looks good.
Just one nit is to add a dot at the end of this comment:
280 // time. It's OK for now as logic in Agent.java forbids multiple agents
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3885
More information about the serviceability-dev
mailing list