RFR: 8265153: add time based test for ThreadMXBean.getThreadInfo() and ThreadInfo.getLockOwnerName() [v5]

Chris Plummer cjplummer at openjdk.java.net
Fri May 14 22:44:54 UTC 2021


On Fri, 14 May 2021 21:54:46 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/monitoring/ThreadInfo/getLockOwnerName/getLockOwnerName.java line 150:
>> 
>>> 148:         System.err.println("where:");
>>> 149:         System.err.println("    -p       ::= print debug info");
>>> 150:         System.err.println("    time_max ::= max looping time in seconds");
>> 
>> `::=` doesn't seem to be a convention we use in help output other than in the other recent tests you've added.
>
> It's a grammar notational style from my compiler theory days.
> I've used '::=' and ':=' for years. What would you like it changed to?
> Or can I just leave it and try to use '-' in the future?

The convention for java tools seems to be to just use tabs to align the start of the argument descriptions:


   -p          print debug info
   time_max    max looping time in seconds

-------------

PR: https://git.openjdk.java.net/jdk/pull/3478


More information about the serviceability-dev mailing list