RFR: 8263635: Add --servername option to jhsdb debugd [v4]

Chris Plummer cjplummer at openjdk.java.net
Fri May 21 01:17:36 UTC 2021


On Thu, 20 May 2021 03:03:09 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

>> `jhsdb debugd` supports server name prefix with `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as remote name for SA RMI object. It is "SARemoteDebugger" by default.
>> 
>> As a result, remote name will be constructed as following:
>> 
>> 
>> //host[:port]/<serverNamePrefix>['_'<id>]
>> 
>> 
>> However we have no way to set it excepting system property. jhsdb should provide the way to set it as a command line option.
>> 
>> serverNamePrefix is used for RMI object name, so "server name" is more suitable for it. Thus I will add `--servername` to `jhsdb debugd` for this purpose.
>> And also we should add the way to specify it when we connect to debug server. I will add it like `--connect id at server:1234/servername`.
>> 
>> I've also filed [CSR for this PR](https://bugs.openjdk.java.net/browse/JDK-8265897). Please review it.
>> This PR modifies DisableRegistryTest.java, but it has been addressed in ProblemList-zgc.txt now. So this PR does not affect ZGC.
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix comments

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/RMIHelper.java line 133:

> 131:                 name = serverNamePrefix;
> 132:             } else {
> 133:                 throw new DebuggerException("Cannot set both sun.jvm.hotspot.rmi.serverNamePrefix and in --servername together");

Remove "in"

-------------

PR: https://git.openjdk.java.net/jdk/pull/3669


More information about the serviceability-dev mailing list