RFR: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load inside a container [v4]

Hao Tang github.com+7947546+tanghaoth90 at openjdk.java.net
Tue May 25 06:25:23 UTC 2021


> OperatingSystemImpl.getCpuLoad() may return 1.0 in a container, even though the CPU load is obviously below 100%.
> 
> We created a 5-core container and run 4 "while (true)" loops in the container. OperatingSystemImpl.getCpuLoad() returned 1.0, which is incorrect (0.8 is correct).
> "systemLoad" in getCpuLoad() is exactly 4.0 before "systemLoad = Math.min(1.0, systemLoad);". The problem is caused by using the elapsed time (specified by "cpu.cfs_period_us") instead of the total CPU time (specified by "cpu.cfs_quota_us"). Therefore, it is more reasonable to divide cpu usage time by "quotaNanos" instead of "elapsedNanos".

Hao Tang has updated the pull request incrementally with one additional commit since the last revision:

  Fix compile errors on MacOS

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3656/files
  - new: https://git.openjdk.java.net/jdk/pull/3656/files/d76fd441..066083e9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3656&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3656&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3656.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3656/head:pull/3656

PR: https://git.openjdk.java.net/jdk/pull/3656


More information about the serviceability-dev mailing list