RFR: 8267842: SIGSEGV in get_current_contended_monitor [v2]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Fri May 28 07:10:06 UTC 2021


On Thu, 27 May 2021 15:19:59 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comments as suggested by Dan.
>
> I wonder if this should be changed to perform the read once by using Atomic::load? That's the guidance we've given the last few years. Some background for this: JDK-8234192.

I agree with @stefank and @dholmes-ora . It is nature to happen the change in thread.hpp to fix this problem.

> Seperately, I'm unclear why we allow this race to exist. I thought we took snapshots when threads were known to be safe and stable. But that is a separate issue.

Now we have Thread-Local handshake. I think we should use it at here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4224


More information about the serviceability-dev mailing list