RFR: 8275729: Qualified method names in CodeHeap Analytics
Evgeny Astigeevich
duke at openjdk.java.net
Tue Nov 2 18:14:23 UTC 2021
On Tue, 2 Nov 2021 05:49:30 GMT, Yi Yang <yyang at openjdk.org> wrote:
>> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be qualified.
>> Testing:
>> - `make test TEST="gtest"`: Passed
>> - `make run-test TEST="tier1"`: Passed
>> - `make run-test TEST="tier2"`: Passed
>> - `make run-test TEST=serviceability/dcmd/compiler/CodeHeapAnalyticsMethodNames.java`: Passed
>
> This looks good now. Old output can not tell us which class the method belongs to.
>
>
> Old:
> 0x00007f6e91063010 (+0x00000010) 0x000000a0( 0K) none 0 480 nMethod (deopt) nmethod
> 0x00007f6e91063310 (+0x00000310) 0x000000f8( 0K) none 0 480 nMethod (active) name()Ljava/lang/String;
> 0x00007f6e91063610 (+0x00000610) 0x000000f8( 0K) none 0 480 nMethod (active) descriptor()Ljava/lang/module/ModuleDescriptor;
> 0x00007f6e91063910 (+0x00000910) 0x00000000( 0K) none 0 480 nMethod (active) getReferenceVolatile(Ljava/lang/Object;J)Ljava/lang/Object;
> 0x00007f6e91063d90 (+0x00000d90) 0x00000000( 0K) none 0 480 nMethod (active) hashCode()I
> 0x00007f6e91064190 (+0x00001190) 0x000000f8( 0K) c1 1 480 nMethod (active) name()Ljava/lang/String;
> 0x00007f6e91064490 (+0x00001490) 0x000000f8( 0K) c1 1 480 nMethod (active) modifiers()Ljava/util/Set;
> 0x00007f6e91064790 (+0x00001790) 0x000000f8( 0K) c1 1 480 nMethod (active) targets()Ljava/util/Set;
> 0x00007f6e91064a90 (+0x00001a90) 0x000000f8( 0K) c1 1 480 nMethod (active) source()Ljava/lang/String;
> 0x00007f6e91064d90 (+0x00001d90) 0x000000f8( 0K) c1 1 480 nMethod (active) isEmpty()Z
> New:
>
> 0x00007f08adc94010 (+0x00000010) 0x00000150( 0K) c1 3 480 nMethod (deopt) nmethod
> 0x00007f08adc94390 (+0x00000390) 0x000001b0( 0K) c1 3 480 nMethod (active) java.lang.String.isLatin1()Z
> 0x00007f08adc94710 (+0x00000710) 0x00000258( 0K) c1 3 480 nMethod (active) jdk.internal.util.Preconditions.checkIndex(IILjava/util/function/BiFunction;)I
> 0x00007f08adc94b90 (+0x00000b90) 0x000004e8( 1K) c1 3 480 nMethod (deopt) nmethod
> 0x00007f08adc95310 (+0x00001310) 0x00000298( 0K) c1 3 480 nMethod (active) java.lang.StringLatin1.charAt([BI)C
> 0x00007f08adc95790 (+0x00001790) 0x000001a0( 0K) c1 3 480 nMethod (active) java.lang.String.checkIndex(II)V
> 0x00007f08adc95b10 (+0x00001b10) 0x00000170( 0K) c1 3 480 nMethod (active) java.lang.String.coder()B
> 0x00007f08adc95e90 (+0x00001e90) 0x000003e8( 0K) c1 3 480 nMethod (active) java.lang.String.hashCode()I
> 0x00007f08adc96490 (+0x00002490) 0x00000130( 0K) c1 3 480 nMethod (deopt) nmethod
> 0x00007f08adc96790 (+0x00002790) 0x00000210( 0K) c1 3 480 nMethod (active) java.lang.String.length()I
Thanks for reviewing @kelthuzadx and @TobiHartmann.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6200
More information about the serviceability-dev
mailing list