RFR: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes [v10]

[Robbin Ehn]

On Wed, 3 Nov 2021 01:19:21 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8249004.cr2.patch
>
> src/hotspot/share/runtime/handshake.cpp line 350:
> 
>> 348: }
>> 349: 
>> 350: void Handshake::execute(HandshakeClosure* hs_cl, ThreadsListHandle* tlh_p, JavaThread* target) {
> 
> Nit: can we drop the `_p` part of `tlh_p` please.

Yes, please.

> src/hotspot/share/runtime/thread.cpp line 1764:
> 
>> 1762:   guarantee(Thread::is_JavaThread_protected(this, /* checkTLHOnly */ true),
>> 1763:             "missing ThreadsListHandle in calling context.");
>> 1764:   if (is_exiting()) {
> 
> Can't we remove this the same as we did for `java_suspend()`?

Yes, please

-------------

PR: https://git.openjdk.java.net/jdk/pull/4677