Integrated: 8276173: Clean up and remove unneeded casts in HeapDumper
Leo Korinth
lkorinth at openjdk.java.net
Fri Nov 5 09:46:17 UTC 2021
On Tue, 2 Nov 2021 13:51:42 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
> HeapDumper does a lot of unneeded casts. Some arguments should be const. Headers are not correctly sorted. Comment about identifier size on Windows and Solaris is not true.
>
> First I cleaned up casting in the "union casting", but then I decided it was better to create a temporary bit_cast that we can use until we get the proper one in c++20.
This pull request has now been integrated.
Changeset: 3c0faa73
Author: Leo Korinth <lkorinth at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/3c0faa73522bd004b66cb9e477f43e15a29842e6
Stats: 53 lines in 1 file changed: 8 ins; 14 del; 31 mod
8276173: Clean up and remove unneeded casts in HeapDumper
Reviewed-by: coleenp, hseigel
-------------
PR: https://git.openjdk.java.net/jdk/pull/6211
More information about the serviceability-dev
mailing list