RFR: 8276337: Use override specifier in HeapDumper [v2]

Leo Korinth lkorinth at openjdk.java.net
Fri Nov 5 16:30:10 UTC 2021


On Fri, 5 Nov 2021 14:30:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   restart failed github tests
>
> src/hotspot/share/services/heapDumper.cpp line 626:
> 
>> 624:   void deactivate() override            { flush(); _backend.deactivate(); }
>> 625:   // Get the backend pointer, used by parallel dump writer.
>> 626:   CompressionBackend* backend_ptr()     { return &_backend; }
> 
> Unrelated, but could be a const method, no?

Not easily I think, if I make the method const, I would have to return a const pointer, and then I need to do const operations on the backend etc.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6274


More information about the serviceability-dev mailing list