RFR: 8276209: Some call sites doesn't pass the parameter 'size' to SharedRuntime::dtrace_object_alloc(_base) [v3]

[David Holmes]

On Mon, 8 Nov 2021 02:42:58 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of this fix that corrects the oop size value of dtrace_object_alloc(_base).
>> 
>> JDK-8039904 added a new parameter 'size' to SharedRuntime::dtrace_object_alloc and dtrace_object_alloc_base, but didn't modified the callsites(interpreter/c1/c2).
>> 
>> To make this fix as simple as possible, I overloaded dtrace_object_alloc_base rather than dtrace_object_alloc.
>> 
>> Thanks,
>> Denghui
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update according to comments

Did your change actually work? I just realized that you can't use this:

```__ call(RuntimeAddress(CAST_FROM_FN_PTR(address, static_cast<int (*)(oopDesc*)>(SharedRuntime::dtrace_object_alloc))));```

because it has no idea what overload of `dtrace_object_alloc` needs to be invoked.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/6181