RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v10]

[Richard Reingruber]

On Wed, 10 Nov 2021 01:27:40 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comment as suggested by Chris.
>
> src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 2194:
> 
>> 2192:         debugMonitorExit(threadLock);
>> 2193:         eventHandler_lock();
>> 2194:         debugMonitorEnter(threadLock);
> 
> The lines 2192-2194 look like a hack to me.
> But I see you have filed an enhancement to fix this.
> I'm okay to address it later.

Thanks for looking at this Serguei.
I agree that this part looks a little odd. It is still correct, though, and the changes are limited to the hardly used code responsible for handling j.l.Thread.resume() calls which is a good thing IMHO.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5849