RFR: 8274982: Add a test for 8269574.

Serguei Spitsyn sspitsyn at openjdk.java.net
Wed Nov 10 22:42:33 UTC 2021


On Mon, 11 Oct 2021 09:55:28 GMT, Evgeny Nikitin <enikitin at openjdk.org> wrote:

> This PR contains a relatively simple test which verifies that JVMTI-agents are correctly informed about exceptions caught in C2-compiled code. The 8269574 introduces pre-allocated exceptions in some paths, so the test tries to produce a number of various exceptions and check that provided small JVMTI agent got notified about all of them.

Hi Evgeny,
New test looks good to me.
I've inlined a couple of minor comments/suggestions.
Thanks,
Serguei

test/hotspot/jtreg/compiler/jvmti/libTriggerBuiltinExceptions.cpp line 77:

> 75:         }
> 76: 
> 77:     } while (false);

I'm not sure why the while (false) loop is needed.
You can always return JNI_ERR instead of break in all places where the
result != JVMTI_ERROR_NONE is detected and return JNI_OK at the end.
Is it to for one-return style?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5889


More information about the serviceability-dev mailing list