RFR: JDK-8276983: Small fixes to DumpAllocStat::print_stats

[Thomas Stuefe]

On Mon, 15 Nov 2021 00:39:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> When looking at CDS code in the context of Lilliput, I had to spend some time in DumpAllocStat::print(). I noticed two small things which can be fixed independently:
>> 
>> - the divide-by-zero check at lines 45ff is not needed, since `percent_of` does this already. It also can cause the asserts at the end of the function to fire wrongly.
>> 
>> - About those asserts: it makes sense to flush the debug message before scope end, otherwise, we won't see the debug message if the asserts fire. If they fire, the debug message would be helpful.
>> 
>> I also improved the assert message somewhat. I noticed that all sizes in this method are `int`, but left it that way because changing it would have too many ripple effects. I guess we won't get CDS archives beyond int_max any time soon.
>> 
>> Thanks, Thomas
>
> Hi Thomas,
> 
> Seems okay. Relying on percent_of rather than passing in 1 does seem to change what will be output, but AFAICS we should never be able to pass zero in the first place.
> 
> Thanks,
> David

Thanks @dholmes-ora and @iklam !

-------------

PR: https://git.openjdk.java.net/jdk/pull/6347