RFR: JDK-8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes

[David Holmes]

On Tue, 16 Nov 2021 01:54:28 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Well, it warns in case of programming errors. I agree, that programming error is very unlikely since the caller has all the information he needs. And he could pass in the wrong count. 
>> 
>> Idk. Mostly I changed this interface to follow the established pattern of always passing in an explicit output buffer size. And to keep it symmetric to``jmm_GetDiagnosticCommandArgumentsInfo` and `jmm_GetGCExtAttributeInfo`. If you object, I'll remove this part.
>
> Hi Thomas,
> 
> I kind of agree with David.
> The symmetry does not help in this case as it creates a bit of confusion. :)
> 
> Thanks,
> Serguei

Thomas, please drop this part. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6363