Integrated: 8274662: Replace 'while' cycles with iterator with enhanced-for in jdk.hotspot.agent

Andrey Turbanov duke at openjdk.java.net
Tue Nov 16 11:21:40 UTC 2021


On Wed, 22 Sep 2021 08:58:01 GMT, Andrey Turbanov <duke at openjdk.java.net> wrote:

> There are few places in code where manual `while` loop is used with Iterator to iterate over Collection.
> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
> It doesn't have any performance impact: javac compiler generates similar code when compiling enhanced-for cycle.
> 
> Similar cleanups:
> * https://bugs.openjdk.java.net/browse/JDK-8258006
> * https://bugs.openjdk.java.net/browse/JDK-8257912

This pull request has now been integrated.

Changeset: c06df25a
Author:    Andrey Turbanov <turbanoff at gmail.com>
Committer: Serguei Spitsyn <sspitsyn at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c06df25a4fb76ee65d3fa99ec0579ca4a406c345
Stats:     16 lines in 2 files changed: 0 ins; 8 del; 8 mod

8274662: Replace 'while' cycles with iterator with enhanced-for in jdk.hotspot.agent

Reviewed-by: amenkov, cjplummer, sspitsyn

-------------

PR: https://git.openjdk.java.net/jdk/pull/5630


More information about the serviceability-dev mailing list