RFR: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be" [v3]

David Holmes dholmes at openjdk.java.net
Mon Nov 22 02:08:05 UTC 2021


On Fri, 19 Nov 2021 10:15:05 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1625:
>> 
>>> 1623:     return; /* JVMTI_ERROR_THREAD_NOT_ALIVE (default) */
>>> 1624:   }
>>> 1625:   assert(_state->get_thread() == java_thread, "Must be");
>> 
>> The `assert()` on L1625 is subject to the same race as the original site.
>> This `is_exiting()` check is made under the protection of the
>> `JvmtiThreadState_lock` so it is sufficient to protect that `assert()`.
>
> Okay, thanks!

Same comment as above.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6440


More information about the serviceability-dev mailing list