RFR: 8274670: Improve version string handling in SA [v2]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Mon Oct 4 13:02:41 UTC 2021


On Mon, 4 Oct 2021 12:07:02 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove toString() calls
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMVersionMismatchException.java line 37:
> 
>> 35: 
>> 36:     public String getMessage() {
>> 37:         return "Supported versions are " + supportedVersions.toString() +
> 
> Why do you call to `toString()` explicitly here? String concatenation will do it for you without it.

I'm not particular about `toString()` call, so I removed them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5797


More information about the serviceability-dev mailing list