RFR: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi
Alan Bateman
alanb at openjdk.java.net
Tue Oct 5 07:29:10 UTC 2021
On Sat, 18 Sep 2021 21:35:41 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:
> There are few places in code where manual while loop is used with Iterator to iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
> It doesn't have any performance impact: java compiler generates similar code when compiling enhanced-for cycle.
>
> Similar cleanups:
> * https://bugs.openjdk.java.net/browse/JDK-8258006
> * https://bugs.openjdk.java.net/browse/JDK-8257912
This code pre-dates for-each, the changes look okay.
-------------
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5577
More information about the serviceability-dev
mailing list