RFR: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi [v2]

Andrey Turbanov github.com+741251+turbanoff at openjdk.java.net
Wed Oct 6 07:00:34 UTC 2021


> There are few places in code where manual while loop is used with Iterator to iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
> It doesn't have any performance impact: java compiler generates similar code when compiling enhanced-for cycle.
> 
> Similar cleanups:
> * https://bugs.openjdk.java.net/browse/JDK-8258006
> * https://bugs.openjdk.java.net/browse/JDK-8257912

Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:

  8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi
  remove redundant spaces before casts

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5577/files
  - new: https://git.openjdk.java.net/jdk/pull/5577/files/7e93b316..1de15c21

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5577&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5577&range=00-01

  Stats: 12 lines in 5 files changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5577.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5577/head:pull/5577

PR: https://git.openjdk.java.net/jdk/pull/5577


More information about the serviceability-dev mailing list