Integrated: 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi

Andrey Turbanov github.com+741251+turbanoff at openjdk.java.net
Thu Oct 7 09:41:21 UTC 2021


On Sat, 18 Sep 2021 21:35:41 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> There are few places in code where manual while loop is used with Iterator to iterate over Collection.
> Instead of manual while cycles it's preferred to use enhanced-for cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
> It doesn't have any performance impact: java compiler generates similar code when compiling enhanced-for cycle.
> 
> Similar cleanups:
> * https://bugs.openjdk.java.net/browse/JDK-8258006
> * https://bugs.openjdk.java.net/browse/JDK-8257912

This pull request has now been integrated.

Changeset: d5ccfa2a
Author:    Andrey Turbanov <turbanoff at gmail.com>
Committer: Serguei Spitsyn <sspitsyn at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/d5ccfa2ae965a9ae0f3597b0b90d702a3e0ea558
Stats:     81 lines in 9 files changed: 0 ins; 35 del; 46 mod

8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi

Reviewed-by: alanb, amenkov, sspitsyn, cjplummer

-------------

PR: https://git.openjdk.java.net/jdk/pull/5577


More information about the serviceability-dev mailing list