RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v4]

Richard Reingruber rrich at openjdk.java.net
Tue Oct 12 08:03:25 UTC 2021


On Tue, 12 Oct 2021 05:59:28 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve @summary section of test.
>
> test/jdk/com/sun/jdi/ResumeAfterThreadResumeCallTest.java line 31:
> 
>> 29:  *          the JDWP agent (in blockOnDebuggerSuspend()) because it called
>> 30:  *          j.l.Thread.resume() on a thread R that was suspended by the
>> 31:  *          debugger.
> 
> This is hard to follow. Maybe instead document the steps the test takes. For example maybe something like: Suspend Thread R via breakpoint. Thread T calls j.l.Thread.resume() on Thread R, resulting in Thread T blocking in blockOnDebuggerSuspend. Resume Thread R using ThreadReference.resume(). Verify that Thread T is no longer  blocked in blockOnDebuggerSuspend.
> 
> Also, it would be nice if thread names in the description matched the names used in the implementation.

Thanks for looking at this. I've updated the test summary.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5849


More information about the serviceability-dev mailing list